started cleaning up JsonProvider usage #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
…ider. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request focuses on cleaning up JsonProvider usage across the Teku codebase, primarily in the data exchange and serialization components.
- Replaced JsonProvider with JsonUtil for JSON serialization/deserialization in multiple classes
- Refactored data structures (e.g., Metadata, SignedAttestation) to use records and Optional for improved type safety
- Removed several custom deserializers (e.g., GetNewBlockResponseDeserializer) and updated related test classes
- Introduced new Attestation and Block record classes for slashing protection interchange data
- Updated SlashingProtectionInterchangeTestExecutor to use modern Java features and improve readability
29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
gfukushima
reviewed
Aug 19, 2024
...dataexchange/src/main/java/tech/pegasys/teku/data/slashinginterchange/SignedAttestation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog