Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8767 electra blob config params #8800

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Oct 31, 2024

PR Description

Add new Electra blob config params

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024
MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4 

This PR adds all the new params but only 2 of them are in use:

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024

The target blobs per block and the max blobs per block usage will be added in a separate PR

MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4 

Fixed Issue(s)

fixes #8767

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi force-pushed the 8767-electra-blob-config-params branch from 133abe5 to 1085e70 Compare November 4, 2024 16:00
@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review November 4, 2024 16:15
@mehdi-aouadi mehdi-aouadi changed the base branch from electra-devnet-5 to master November 4, 2024 20:39
@mehdi-aouadi
Copy link
Contributor Author

Will raise separate smaller PRs instead

@mehdi-aouadi mehdi-aouadi deleted the 8767-electra-blob-config-params branch November 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support config params to change blobs number on Electra
1 participant