Added SingleAttestationEvent #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if the attestation arriving is a singleAttestation, will fire a single_attestation event, otherwise will trigger an attestation event. - at the moment we only see attestations, but added unit test and can re-verify once we have single attestations being produced... - can essentially listen to both by : `curl -H "Accept:text/event-stream" -N http://localhost:5051/eth/v1/events\?topics\=attestation,single_attestation` Signed-off-by: Paul Harris <[email protected]>
tbenr
reviewed
Dec 3, 2024
we haven't ever maintained that list, its basically just wrong but i'll try to make it less random. |
Signed-off-by: Paul Harris <[email protected]>
lucassaldanha
approved these changes
Dec 3, 2024
Signed-off-by: Paul Harris <[email protected]>
…ingle-attestation-event
tbenr
reviewed
Dec 4, 2024
| + EnumSet.allOf(EventType.class).stream() | ||
| .map(val -> "`" + val.toString() + "`") | ||
| .sorted() | ||
| .collect(Collectors.joining(", ")), |
There was a problem hiding this comment.
haven't you missed the closing ] here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the attestation arriving is a singleAttestation, will fire a single_attestation event, otherwise will trigger an attestation event.
at the moment we only see attestations, but added unit test and can re-verify once we have single attestations being produced...
can essentially listen to both by :
curl -H "Accept:text/event-stream" -N http://localhost:5051/eth/v1/events\?topics\=attestation,single_attestationDocumentation
doc-change-requiredlabel to this PR if updates are required.Changelog