Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra ref-test alpha.9 update #8882

Merged

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Dec 4, 2024

PR Description

This PR has 3 fixes:

  • Electra state upgrade
  • Pending partial withdrawals
  • Add missed exit checks to consolidation processing

Also, we are adding one reference test to the ignore list invalid_nonset_bits_for_one_committee to be fixed in a separate issue (#8892).

Another thing is we disabled fuzzConsolidationRequest_minimal on FuzzUtilTest. We will look at fixing it as part of #8876

Electra state upgrade

I found an issue with our calculation while running the latest reference tests. We were not taking into consideration when:
earliest_exit_epoch = compute_activation_exit_epoch(get_current_epoch(pre)) is greater than the max exitEpoch from our validator set.

The current change should match this:

earliest_exit_epoch = compute_activation_exit_epoch(get_current_epoch(pre))
    for validator in pre.validators:
        if validator.exit_epoch != FAR_FUTURE_EPOCH:
            if validator.exit_epoch > earliest_exit_epoch:
                earliest_exit_epoch = validator.exit_epoch
    earliest_exit_epoch += Epoch(

Spec Reference: https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/fork.md#upgrading-the-state

Pending partial withdrawals

Add missed exit checks to consolidation processing

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha changed the title fix electra fork upgrade Fix Electra fork upgrade code Dec 4, 2024
@lucassaldanha lucassaldanha force-pushed the fix-electra-fork-upgrade branch from 583a6c4 to f2bdbeb Compare December 4, 2024 01:44
Copy link
Contributor

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was a recent change by the way.

Included in the alpha.9 release two weeks ago:

I suspect the reference tests are failing because Teku is using alpha.8 right now.

@jtraglia
Copy link
Contributor

jtraglia commented Dec 4, 2024

Also, the fact that you missed this was my fault. I missed including it in the release notes. See:

@lucassaldanha
Copy link
Member Author

Correct. I'm working on the update to alpha9!

@lucassaldanha lucassaldanha force-pushed the fix-electra-fork-upgrade branch from d18bb39 to afe7063 Compare December 5, 2024 23:23
@lucassaldanha lucassaldanha changed the title Fix Electra fork upgrade code Electra ref-test alpha.9 update Dec 5, 2024
@lucassaldanha lucassaldanha merged commit a8c2e0e into Consensys:master Dec 6, 2024
17 checks passed
@lucassaldanha lucassaldanha deleted the fix-electra-fork-upgrade branch December 6, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants