fix(schema-compiler): YAML - crash on unammed measure/dimension/join,…

… refs cube-js#7033 (cube-js#7142)
ConsultingMD · Sep 18, 2023 · 5c6a065 · 5c6a065
1 parent 73f5ca7
commit 5c6a065
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts b/packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts
@@ -287,8 +287,9 @@ export class YamlCompiler {
       if (memberType === 'preAggregation' && indexes) {
         indexes = this.yamlArrayToObj(indexes || [], `${memberType}.index`, errorsReport);
       }
+
       if (!name) {
-        errorsReport.error(`name isn't defined for ${memberType}: ${YAML.stringify(rest)}`);
+        errorsReport.error(`name isn't defined for ${memberType}: ${JSON.stringify(rest)}`);
         return {};
       } else if (indexes) {
         return { [name]: { indexes, ...rest } };

diff --git a/packages/cubejs-schema-compiler/test/unit/yaml-schema.test.ts b/packages/cubejs-schema-compiler/test/unit/yaml-schema.test.ts
@@ -89,4 +89,25 @@ describe('Yaml Schema Testing', () => {
       expect(e.message).toContain('Unexpected input during yaml transpiling: null');
     }
   });
+
+  it('unammed measure', async () => {
+    const { compiler } = prepareYamlCompiler(
+      `cubes:
+  - name: Users
+    sql: SELECT * FROM e2e.users
+    dimensions:
+      - sql: id
+        type: number
+        primaryKey: true
+      `
+    );
+
+    try {
+      await compiler.compile();
+
+      throw new Error('compile must return an error');
+    } catch (e: any) {
+      expect(e.message).toContain('name isn\'t defined for dimension: ');
+    }
+  });
 });