Skip to content

Commit

Permalink
fix 'rdctl: command not found' (#91)
Browse files Browse the repository at this point in the history
@cobbr2 saw this error while testing recent
[changes](b3df8cd):
```
=> Moving App 'Rancher Desktop.app' to '/Applications/Rancher Desktop.app'
:beer:  ih-rancher was successfully installed!
INFO[0000] About to launch /usr/bin/open -a /Applications/Rancher Desktop.app ...
In order to continue with Rancher configuration and be able to use this engine, some IDEs require the creation of symlinks for remote Python interpreters
Your password is required for the creation of symlink mentioned above
ln: /usr/local/bin/docker: File exists
ln: /usr/local/bin/docker-compose: File exists

Parse error: bad token
    <stdin>:1

/opt/homebrew/Cellar/ih-core/0.1.51/lib/core/rancher/step.sh: line 170: rdctl: command not found
Rancher Desktop has been installed successfully
```

rdctl should be installed at that point of the script, and `rdctl` works
for me locally.

This PR tries using `$HOME/.rd/bin/rdctl` instead.
  • Loading branch information
pb-dod authored Apr 12, 2024
1 parent b3df8cd commit 588335d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.51
0.1.52
2 changes: 1 addition & 1 deletion formula/ih-core.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class IhCore < Formula
VERSION="0.1.51"
VERSION="0.1.52"
desc "Brew formula for installing core tools used at Included Health engineering."
homepage "https://github.com/ConsultingMD/homebrew-ih-public"
license "CC BY-NC-ND 4.0"
Expand Down
2 changes: 1 addition & 1 deletion lib/core/rancher/step.sh
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function ih::setup::core.rancher::install() {
elif ! grep -q "<string>vz</string>" "$PLIST_DST"; then
ih::log::debug "Updating PLIST to use 'vz' for Virtualization for M3 Macs."
sudo sed -i '' 's/<string>qemu<\/string>/<string>vz<\/string>/g' "$PLIST_DST"
rdctl set --experimental.virtual-machine.mount.type virtiofs
$HOME/.rd/bin/rdctl set --experimental.virtual-machine.mount.type virtiofs
fi
fi

Expand Down

0 comments on commit 588335d

Please sign in to comment.