CLOUD-4745: ensure certificates are up to date #104
Merged
+30
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certificates step wasn't detecting when updates were needed on existing systems. This became apparent when @hochdave encountered issues where his system had outdated certificates, but ih-setup's test function wasn't detecting this and triggering an update.
Specifically, this manifested as an issue @hochdave had with
NODE_EXTRA_CA_CERTS
pointing to an outdated certificate path, causing npm install failures.Solution
Added file comparison checks to ensure both the certificates and their configuration files match their source versions. If either is out of date, the step will trigger a reinstall.
Changes include:
diff
checks in thetest()
function to compare installed files with their sourcesTesting
Tested using the isolated environment test script. Verified that: