change the status to concurrent query failed #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2024 19:07
mga-chka
reviewed
Mar 23, 2024
| return r.updateTransactionState(key, []byte{uint8(transactionCompleted)}) | ||
| } | ||
|
|
||
| func (r *redisTransactionRegistry) Fail(key *Key, reason string) error { | ||
| func (r *redisTransactionRegistry) Fail(key *Key, statusCode int, reason string) error { |
There was a problem hiding this comment.
becareful because you don't serialize the statusCode in redis.
Therefore, your fix won't always work (depending on the configuration used). If you start changing the serialization, you also take into account the backward compatibility
|
I'm pinging you just in case you didn't see the comments @NatSau02 |
|
since I accepted the PR #407, I'm removing this one, cf the previous discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#404
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments