Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAR #3161

Merged
merged 12 commits into from
Oct 21, 2024
Merged

SAR #3161

merged 12 commits into from
Oct 21, 2024

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Oct 9, 2024

Still work in progress

I have tested that the restore works from client and service.
There are preferences to allow us to configure so that everything works as it used to.

I still can't get some of the DAO tests ( but I think this is a problem in my end / elastic setup )

@shroffk shroffk changed the title Sar SAR Oct 9, 2024
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, but restore from client does not take advantage of
SnapshotUtil.restore().

@shroffk shroffk marked this pull request as ready for review October 11, 2024 17:49
@shroffk
Copy link
Member Author

shroffk commented Oct 14, 2024

Fixed the app so that the client uses the same utility class for client side restore too.

@shroffk
Copy link
Member Author

shroffk commented Oct 14, 2024

@georgweiss this is ready for now

There are a few TODOs but we can open separate PR's

  • preference/properties reading in the utility which functions correctly both in Phoebus and in the Springboot service.

@shroffk shroffk merged commit 323b72e into master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants