assemble pages and then look for claims #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,14 +22,30 @@ def process_and_visualize_claims(docmgr, output_file: str = "claims_analysis.htm | |||
| print(f"First metadata sample: {results['metadatas'][0]}") | |||
| else: | |||
| print("No documents found in collection! Exiting") | |||
| exit | |||
| return | |||
There was a problem hiding this comment.
- If we pass a new pdf, it will be processed by
doc_manager.process_pdf(args.pdf)in 'main()', so how could this else statement happen unless there is not text in the pdf. - Testing code on new pdf not processed before doesn't work as it return instead of processing the pdf and complete
| def sort_key(x): | ||
| metadata = x[1] | ||
| if 'bbox' in metadata: | ||
| return (metadata['page'], metadata['bbox'][1]) # Sort by page, then y-coord |
There was a problem hiding this comment.
It gets the page number without checking the PDF source. So it get's all text from page n, whatever it belongs to any pdf
| page_text = "" | ||
| for text, metadata in pages[page_num]: | ||
| if metadata.get('type') == 'text': # Skip images | ||
| page_text += text + "\n\n" |
There was a problem hiding this comment.
images' text can be added at the end of page_text after adding all direct text
zeyadhessuin
requested changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.