Dependency clean-ups #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MevenBertrand
force-pushed
the
dependency-cleanup
branch
from
cf22d43 to
a7e663a
Compare
|
I would prefer not to touch any of the dependencies of the files in the LogicalRelation and Validity directories because I'm changing all of them anyway in the branch rmredtyeq |
|
Fair! I'll keep this one lying around for the time being to fix the dependency graph at least on my side, and we can get rid of it once your changes get merged. Maybe you can you check whether the issue (duplication of nodes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66 broke the dependency graph. The root cause is that apparently
coqdepis not smart enough to disambiguate thatFrom LogRel.LogicalRelation Require Import Universe.creates a dependency of the current file onLogicalRelation.Introductions.Universe. Not sure whether this is something worth reporting on the Coq side… Anyway, this is fixed the dumb way by doing more qualified names in all imports.I also took the liberty to clean-up some unnecessary dependencies, too. Maybe at some point we should run Jason's dependency minimisation script? Or even try to untangle a bit the big knot that is the dependency graph of the logical relation? I really have no clue of what's happening there.