Skip to content

Commit

Permalink
fix: fix the way semantic-release operates
Browse files Browse the repository at this point in the history
  • Loading branch information
CorentinDeBoisset committed Jan 12, 2024
1 parent 8f42830 commit ece9e9e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/branches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,13 @@ jobs:
contents: write # Allow the job to write tags on the repo
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false # to avoid using GITHUB_TOKEN when pushing

# It's required to avoid using the GITHUB_TOKEN, because we want an action to run on the tags that will be pushed.
# By default, github actions does not run on events triggered by other actions
- name: Run semantic release
uses: cycjimmy/semantic-release-action@v4
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_PUSH_TOKEN }}
NPM_TOKEN: ""
6 changes: 3 additions & 3 deletions .github/workflows/tags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ concurrency:
on:
push:
tags:
- '[0-9]\.[0-9]\.[0-9]*'
- 'v[0-9]\.[0-9]\.[0-9]*'

jobs:
release:
Expand Down Expand Up @@ -42,5 +42,5 @@ jobs:
context: .
file: ./docker_build/Dockerfile
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
tags: ${{ steps.docker_meta.outputs.tags }}
labels: ${{ steps.docker_meta.outputs.labels }}
1 change: 0 additions & 1 deletion .releaserc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"tagFormat": "${version}",
"branches": [
"+([0-9])?(.{+([0-9]),x}).x",
"main",
Expand Down

0 comments on commit ece9e9e

Please sign in to comment.