Новые команды setallbalance и setbalance #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireNameFN
requested changes
Jun 4, 2024
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
Content.Server/Administration/Commands/CorvaxSetBalanceCommand.cs
Outdated
Show resolved
Hide resolved
FireNameFN
reviewed
Jun 6, 2024
| { | ||
| var loc = IoCManager.Resolve<ILocalizationManager>(); | ||
| var set_balance = 0; | ||
| int.TryParse(args[1], out set_balance); |
There was a problem hiding this comment.
Вот этот мусор сделает всем плохо.
JerryImMouse
reviewed
Jun 8, 2024
Comment on lines
+267
to
+269
| await using var db = await GetDb(); | ||
| await db.DbContext.Database.ExecuteSqlAsync($"""UPDATE profile SET bank_balance = {set_balance}"""); | ||
| await db.DbContext.SaveChangesAsync(); |
There was a problem hiding this comment.
SQL инъекции привет передают
There was a problem hiding this comment.
var parameters = new[]
{
new SqlParameter("@balance", setBalance),
};
await db.DbContext.Database.ExecuteSqlRawAsync(query, parameters);There was a problem hiding this comment.
@JerryImMouse а ты видишь какие параметры передаются в функцию? Как ты строку в инт передашь?
|
Пусть висит в открытых, это на новый год. |
|
🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setallbalance и setbalance команды по заказу кмина
ДЛЯ РАБОТЫ КОМАНД НАДО ПЕРЕЗАГРУЗИТЬ СЕРВЕР ТАК КАК ОНИ МЕНЯЮТ ДАННЫЕ В БАЗЕ ДАННЫХ.
То есть можно засетать 0 даже тому кто сейчас не на сервере