New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues in the devices.json file #45

Open

PiotrZPL wants to merge 2 commits into CorvusRom-Devices:main from PiotrZPL:main

PiotrZPL commented Jan 23, 2023

While parsing your file, I encountered two problems:

Veux (Redmi Note 11 Pro 5G/ Poco X4 Pro 5G) was declared twice in the Xiaomi section. It is problematic, as JSON does not allow duplicate declarations, and such issues may lead some parsers to fail. In order to fix it, I removed the outdated declaration.
Payton (Moto X4) was declared in the Xiaomi section. As this device was manufactured by Motorola, I moved it to its appropriate section.

PiotrZPL added 2 commits

January 23, 2023 13:42


          Removed duplicate declaration of veux

69f090b


          Moved payton to the Motorola section

b5904d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet