lock implementation for runtime resource publishing #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fadedreamz <[email protected]>
|
@ben-crowhurst please have a look and give your suggestion |
|
Tests are failing. |
Signed-off-by: fadedreamz <[email protected]>
|
Thanks looks good. I'll pull it into master once we've tag the 4.5 release as the project is currently feature frozen. |
|
@ben-crowhurst glad to hear that |
|
Hi there, please note that the write_lock should be created under the suppress function as well so that at runtime both publish and suppress functionality will be available. Eran |
Signed-off-by: Nuno Goncalves <[email protected]>
DNS resolution error currently causes indefinite hangup as the callback is not called and higher-level layers are not informed. This commit bubbles up the error, allowing the request to fail.
Fix various issues preventing compilation in some environments (e.g. cross-compiling with mingw) on a case-sensitive system, and use the official _WIN32 macro to detect the Win32 environment as WIN32 is not always defined.
|
hi, any news of this feature ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fadedreamz [email protected]