Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/exercise1 #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/exercise1 #2

wants to merge 3 commits into from

Conversation

kswan-NOAA
Copy link

No description provided.

@CoryMartin-NOAA CoryMartin-NOAA changed the base branch from feature/exercise1 to main June 7, 2023 19:30
CoryMartin-NOAA
CoryMartin-NOAA requested changes Jun 7, 2023
View reviewed changes
Copy link
Owner

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor change, but this is just showing how the review process works and how someone can offer suggestions and comments on how to best improve our code!

exercise1/roster.yaml Show resolved Hide resolved
exercise2/Remove Dates Show resolved Hide resolved
CoryMartin-NOAA
CoryMartin-NOAA approved these changes Jun 7, 2023
View reviewed changes
Copy link
Owner

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm not going to merge here, you can change the PR to merge into your fork to merge it in there if you'd like, or we can just close it.

@CoryMartin-NOAA
Copy link
Owner

Also, it's a good idea generally to give your PR a nice title and description, so we know what code you are adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kswan-NOAA @CoryMartin-NOAA