Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VarBC for aerosol DA #5

Open
wants to merge 5 commits into
base: feature/aero-b
Choose a base branch
from
Open

Conversation

ypwang19
Copy link
Collaborator

Description

This PR adds in VarBC configuration for aerosol DA. This PR copy the input bias files to {DATA}/bc and copy back the output bias files to analysis/chem.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Owner

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we wait to merge this in once NOAA-EMC#2862 is done so it is done consistently across different systems. Thoughts?

@andytangborn
Copy link
Collaborator

I'm wondering if we wait to merge this in once NOAA-EMC#2862 is done so it is done consistently across different systems. Thoughts?

Is this issue going to result in a PR being merged into feature/aero-b ? I would assume that it is best to merge this in before feature/aero-b gets merged into develop.

@CoryMartin-NOAA
Copy link
Owner

Problem is, I think feature/aero-b is 'ready' to merge, and if this gets added, we will have to go through the testing process again, so I would prefer to do that when we are sure the coefficients are being handled consistently

@ypwang19
Copy link
Collaborator Author

I agree that we could wait for this work is done. I was not quite sure how to deal with the original code related to statbias files.

I'm wondering if we wait to merge this in once NOAA-EMC#2862 is done so it is done consistently across different systems. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants