-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage-plus
: Introduction and Basics
#21
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks really good!
Just a general stylistical question, should we maybe wrap crate names in backticks (`; so inline code blocks) instead of wrapping them in stars (*).
Because I see italics for emphasising things, while backticks are more suited for technical things (such as crate names and similar things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small comments, and I agree with @aumetra 's - overall LGTM! :)
@aumetra I tend to think of italics as used for proper names (like Newsweek or CosmWasm), and inline code as mostly used for code, variable names, types, and the like. I guess for me crate names tend to fall in the "proper name" category, though I see how that's blurry. Slack poll? |
I think if you rebase the PR, that should pick up commits fixing that deploy problem |
this content is already in Basics
Co-authored-by: Aumetra Weisman <[email protected]>
Rebased! |
I think I applied all the suggestions. Thanks a lot. I'm going to merge since I have approval, but if there's still something to fix, I'm happy to open a new PR. |
Review and merge #20 first!