Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage-plus: Introduction and Basics #21

Merged
merged 6 commits into from
Jun 4, 2024
Merged

storage-plus: Introduction and Basics #21

merged 6 commits into from
Jun 4, 2024

Conversation

uint
Copy link
Contributor

@uint uint commented May 14, 2024

Review and merge #20 first!

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 5:41pm

Base automatically changed from storage-skeleton to main June 4, 2024 13:05
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks really good!
Just a general stylistical question, should we maybe wrap crate names in backticks (`; so inline code blocks) instead of wrapping them in stars (*).

Because I see italics for emphasising things, while backticks are more suited for technical things (such as crate names and similar things)

src/pages/cw-storage-plus/basics.mdx Outdated Show resolved Hide resolved
src/pages/cw-storage-plus/basics.mdx Outdated Show resolved Hide resolved
src/pages/cw-storage-plus/basics.mdx Show resolved Hide resolved
src/pages/cw-storage-plus.md Outdated Show resolved Hide resolved
src/pages/cw-storage-plus.md Outdated Show resolved Hide resolved
src/pages/cw-storage-plus.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small comments, and I agree with @aumetra 's - overall LGTM! :)

src/pages/cw-storage-plus/basics.mdx Outdated Show resolved Hide resolved
src/pages/cw-storage-plus/basics.mdx Outdated Show resolved Hide resolved
@uint
Copy link
Contributor Author

uint commented Jun 4, 2024

In general this looks really good! Just a general stylistical question, should we maybe wrap crate names in backticks (`; so inline code blocks) instead of wrapping them in stars (*).

Because I see italics for emphasising things, while backticks are more suited for technical things (such as crate names and similar things)

@aumetra I tend to think of italics as used for proper names (like Newsweek or CosmWasm), and inline code as mostly used for code, variable names, types, and the like. I guess for me crate names tend to fall in the "proper name" category, though I see how that's blurry. Slack poll?

@aumetra
Copy link
Member

aumetra commented Jun 4, 2024

I think if you rebase the PR, that should pick up commits fixing that deploy problem

@uint uint force-pushed the storage-plus-intro branch from 9b15c57 to ef4500f Compare June 4, 2024 15:00
@uint
Copy link
Contributor Author

uint commented Jun 4, 2024

Rebased!

@uint
Copy link
Contributor Author

uint commented Jun 4, 2024

I think I applied all the suggestions. Thanks a lot.

I'm going to merge since I have approval, but if there's still something to fix, I'm happy to open a new PR.

@uint uint merged commit 209bdba into main Jun 4, 2024
3 checks passed
@uint uint deleted the storage-plus-intro branch June 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants