Allow Value to conditionally implement JsonSchema #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2023
Merged
Closed
github-merge-queue bot
pushed a commit
to ComposableFi/composable
that referenced
this pull request
Aug 3, 2023
#3951) Generally, ensure that setup of storage is easy to do and full of data to do all possible routing (like Osmosis does, but more general in all directions and solvers), and using that setup against Osmosis. So uploaded contracts to Osmosis and initialized. - separate devnet for cosmos only for faster dev - aligned config/folders/messages/transports of xcvm on whole stack - made data folder of dotsama devnet same as cosmos (/tmp/composable-devnet/) - updated XCVM spec as per latest state - added into language, not implemented yet, swap instruction to XCVM named and modelled with parity XCM (will work on parity, picasso, osmosis, problem solver) - tests for assets not compiled, mostly useless and simplistic - removed instead of fixing (tests will be in DevNet directly via bash) - generated schema for xcvm - fixed nix docs/examples to ensure people run properly nix with all parameters - fixed memo handling (again, had to cp paste some code CosmWasm/serde-cw-value#3) and its integration with centauri (now they cannot handle wasm, so it skips it ) - disable run of CI in hash tag (i do not want to spam people) - renamed Multihop XCM IBC some struct as per previos request of @RustNinja - updated cosmos.nix deps to latest centauri - clean up of nix and speed ups builds of nix Required for merge: - [x] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/research/issues/249 https://github.com/ComposableFi/research/issues/244 - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] Added reviewer into `Reviewers` - [x] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production - [x] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big) 
github-merge-queue bot
pushed a commit
to ComposableFi/composable
that referenced
this pull request
Aug 3, 2023
#3951) Generally, ensure that setup of storage is easy to do and full of data to do all possible routing (like Osmosis does, but more general in all directions and solvers), and using that setup against Osmosis. So uploaded contracts to Osmosis and initialized. - separate devnet for cosmos only for faster dev - aligned config/folders/messages/transports of xcvm on whole stack - made data folder of dotsama devnet same as cosmos (/tmp/composable-devnet/) - updated XCVM spec as per latest state - added into language, not implemented yet, swap instruction to XCVM named and modelled with parity XCM (will work on parity, picasso, osmosis, problem solver) - tests for assets not compiled, mostly useless and simplistic - removed instead of fixing (tests will be in DevNet directly via bash) - generated schema for xcvm - fixed nix docs/examples to ensure people run properly nix with all parameters - fixed memo handling (again, had to cp paste some code CosmWasm/serde-cw-value#3) and its integration with centauri (now they cannot handle wasm, so it skips it ) - disable run of CI in hash tag (i do not want to spam people) - renamed Multihop XCM IBC some struct as per previos request of @RustNinja - updated cosmos.nix deps to latest centauri - clean up of nix and speed ups builds of nix Required for merge: - [x] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/research/issues/249 https://github.com/ComposableFi/research/issues/244 - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] Added reviewer into `Reviewers` - [x] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production - [x] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big) 
dzmitry-lahoda
added a commit
to ComposableFi/composable
that referenced
this pull request
Aug 3, 2023
#3951) Generally, ensure that setup of storage is easy to do and full of data to do all possible routing (like Osmosis does, but more general in all directions and solvers), and using that setup against Osmosis. So uploaded contracts to Osmosis and initialized. - separate devnet for cosmos only for faster dev - aligned config/folders/messages/transports of xcvm on whole stack - made data folder of dotsama devnet same as cosmos (/tmp/composable-devnet/) - updated XCVM spec as per latest state - added into language, not implemented yet, swap instruction to XCVM named and modelled with parity XCM (will work on parity, picasso, osmosis, problem solver) - tests for assets not compiled, mostly useless and simplistic - removed instead of fixing (tests will be in DevNet directly via bash) - generated schema for xcvm - fixed nix docs/examples to ensure people run properly nix with all parameters - fixed memo handling (again, had to cp paste some code CosmWasm/serde-cw-value#3) and its integration with centauri (now they cannot handle wasm, so it skips it ) - disable run of CI in hash tag (i do not want to spam people) - renamed Multihop XCM IBC some struct as per previos request of @RustNinja - updated cosmos.nix deps to latest centauri - clean up of nix and speed ups builds of nix Required for merge: - [x] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/research/issues/249 https://github.com/ComposableFi/research/issues/244 - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] Added reviewer into `Reviewers` - [x] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production - [x] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big)  --------- Signed-off-by: dzmitry-lahoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if you want to include value in a message.