Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Allow more gas efficient migrations #1846

Closed
wants to merge 5 commits into from
Closed

[DO NOT MERGE] Allow more gas efficient migrations #1846

wants to merge 5 commits into from

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Mar 29, 2024

Resolves #1813

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.87%. Comparing base (08567ff) to head (ea54914).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   54.89%   54.87%   -0.02%     
==========================================
  Files          64       64              
  Lines        9770     9776       +6     
==========================================
+ Hits         5363     5365       +2     
- Misses       3863     3865       +2     
- Partials      544      546       +2
Files Coverage Δ
x/wasm/keeper/keeper.go 77.86% <84.00%> (-0.36%) ⬇️

@pinosu pinosu marked this pull request as ready for review April 1, 2024 13:33
@pinosu pinosu changed the title [WIP] Allow more gas efficient migrations [DO NOT MERGE] Allow more gas efficient migrations Apr 1, 2024
chipshort
chipshort reviewed Apr 2, 2024
View reviewed changes
x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinosu pinosu added the spike Demo to showcase an idea. label Apr 23, 2024
@webmaster128
Copy link
Member

Thank you! Closing in favour of this solution as discussed: #1924

@webmaster128 webmaster128 deleted the 1813-migrate_check branch July 4, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
spike Demo to showcase an idea.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional migrate entry point – allow more gas efficient migrations
3 participants
@pinosu @webmaster128 @chipshort