Fix random crash (#204) #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quajak
requested changes
Aug 15, 2023
| var v = reader.GetValue(i); | ||
|
|
||
| if(v == null) { | ||
| Console.WriteLine("WARNING: Tried to insert null value"); |
There was a problem hiding this comment.
Do we need the Console.WriteLine here?
We should only keep it if this fix is not final and the actual cause of the issue must be resolved at a later time.
There was a problem hiding this comment.
Well I can remove it because I believe this fix will be permanent as the affected area is only for debugging I think and I highly doubt that the non-existant argument is actually required in the debug data
quajak
approved these changes
Aug 19, 2023
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash as shown in #204