Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical alignment to WDynamicLabel #249

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

MarcusElg
Copy link
Contributor

Closes #202

@MarcusElg
Copy link
Contributor Author

These two prs together with an implementation for #247 would be a perfect release 😉

@MarcusElg MarcusElg requested a review from Juuxel August 4, 2024 07:39
@MarcusElg MarcusElg force-pushed the vertical_alignment_dynamic_text branch 2 times, most recently from a8b210b to 0a36a59 Compare August 4, 2024 12:40
@MarcusElg MarcusElg force-pushed the vertical_alignment_dynamic_text branch from 27d50af to e0f6937 Compare August 14, 2024 19:13
Fix compilation

Push forgotten code

Fix strange docs error
@MarcusElg MarcusElg force-pushed the vertical_alignment_dynamic_text branch from e0f6937 to 88ba615 Compare August 14, 2024 19:17
@MarcusElg
Copy link
Contributor Author

MarcusElg commented Aug 14, 2024

This was just supposed to be a quick edit 😂. But now it finally builds correctly both locally and on github actions

Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@Juuxel Juuxel merged commit bc7cbcb into CottonMC:master Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical alignment for WDynamicLabel
2 participants