chore: add configurations for rails 7.2, ruby {3.2, 3.3} #5
+24
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
2 times, most recently
from
6dbd0b4
to
f68304e
Compare
bivanalhar
reviewed
Sep 3, 2024
There was a problem hiding this comment.
@adi-herwana-nus some comments
Also, make sure to bump the version inside lib/active_record/userstamp/version.rb
| @@ -23,8 +24,19 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| ruby-version: ['3.0', '3.1'] | |||
| activerecord: ['6.0', '6.1', '7.0', '7.1'] | |||
| ruby-version: ['3.0', '3.1', '3.2', '3.3'] | |||
There was a problem hiding this comment.
Same as active-record_acts-as, please just focus the testing for
- Rails 7.0, 7.1, 7.2
- Ruby 3.1, 3.2, 3.3
| @@ -14,6 +14,7 @@ on: | |||
| branches: ['master'] | |||
| schedule: | |||
| - cron: '0 0 * * 0' | |||
There was a problem hiding this comment.
Also, consider removing this scheduling. See the notes from active-record_acts-as
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
4 times, most recently
from
bc33aed
to
7e962f9
Compare
- migrated pipeline from 'coveralls' to 'coveralls_reborn' - bump version and update changelog
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
from
7e962f9
to
42bc36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverallstocoveralls_reborndue to incompatibility with ruby 3.2+.