Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Check-in puma.rb #311

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

jsyeo
Copy link
Contributor

@jsyeo jsyeo commented Dec 8, 2014

lol

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5d876bf on jsyeo:jsyeo-checkin-pumarb into 64ca0a5 on Coursemology:development.


# quiet
threads 0, 30
bind 'unix://tmp/sockets/puma.sock'
threads 10, 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to set so high. this might cause too many requests to be timesliced on one thread.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about min = 0, max = 10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I know what's the "right" number? 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe for mine I used min=1, max=4... but you might wanna tweak this when you have instrumentation.

@@ -9,16 +9,12 @@
# end

environment 'production'
daemonize true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is commented out?

@raymondtangsc
Copy link
Contributor

If this is for our production, you need to check what we have in our production now. Otherwise push this could break things.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b3e0aa4 on jsyeo:jsyeo-checkin-pumarb into 64ca0a5 on Coursemology:development.

@raymondtangsc
Copy link
Contributor

Also, git ignore file currently ignores: /config/puma.rb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants