Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Use capistrano for deploys #425

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jsyeo
Copy link
Contributor

@jsyeo jsyeo commented Apr 28, 2015

instead of that memory hungry jenkins

lol

@@ -0,0 +1,14 @@
lock '3.2.1'

#set :deploy_to, "~/coursemology_deploy"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after #.

@@ -0,0 +1,13 @@
lock '3.2.1'

set :application, 'coursemology'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@jsyeo
Copy link
Contributor Author

jsyeo commented Apr 28, 2015

hey @allenwq, can you spare another pair of eyes to look through this PR? The idea is that we want to use codeship to deploy via capistrano so that we can kill jenkins and free up some memory and space on our server.

@jsyeo
Copy link
Contributor Author

jsyeo commented Apr 28, 2015

Please ignore the hound violations. I will fix that in a separate PR. Thanks!

@@ -1,89 +0,0 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsyeo If this file is removed, what's the new way of restarting the server ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hence capistrano. Use cap production puma:restart from your local machine while in the coursemology dir. There's no need to ssh in to restart it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged, I will then write upstart scripts to manage nginx, puma and delayed job so that they will be automatically started when the server reboots

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, 👍

@@ -64,9 +64,9 @@ GEM
acts_as_paranoid (0.4.3)
activerecord (~> 3.2)
acts_as_votable (0.7.1)
addressable (2.3.6)
addressable (2.3.8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsyeo Can we don't update all the gems or do this in another PR ?

I'm afraid this could introduce some unknown bugs since we don't have enough test cases. Like last time our html5 editor was broken after we installed a new version.

@allenwq
Copy link
Member

allenwq commented Apr 29, 2015

Also, we should fix travis.

@lowjoel
Copy link
Member

lowjoel commented Apr 29, 2015

My concern with this PR is that we're mixing the open source components with our own proprietary information. Might not be a problem for v1, but would definitely need to be addressed for v2. I'm +0 on this for v1, a similar PR for v2 would get a -1 from me...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants