-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yupei/add live feedback history #7511
Merged
syoopie
merged 24 commits into
yupei/add-live-feedback-storage-and-statistics
from
yupei/add-live-feedback-history
Aug 28, 2024
Merged
yupei/add live feedback history #7511
syoopie
merged 24 commits into
yupei/add-live-feedback-storage-and-statistics
from
yupei/add-live-feedback-history
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make the grade and attempt count box clickable refactor(statistics): questionType -> type
- each grade and attempt count cell is clickable - after clicking, the box containing question will appear - fetch question and answer details in one API - use Accordion for question to allow for collapsing question - include grade display inside answer box
- include some minor refactoring in BE and FE of stats
- extend QuestionAnswerDetails to allow polymorphism - reuse existing answer type def for defining its mini version
- Multiple Choice - Multiple Response - Text Response (with/without attachments) - File Upload
- allowAttachment to be changed into maxAttachments nonzero - fix rubocop trailing whitespace issue
- memoize BarChart to allow change when toggling between duplication - refactor SubmissionStatusChart
- per submission question id
- split pages for answerDisplay between attemptCount and marksPerQuestion - create URL for past answers - workflow state chip clickable to submission edit page - className for using tailwind color for workflow state chip
- provide link to past answers and also submission edit page in answer box and past answer page - Slider to show timeline of answers (from earliest to most recent one) - add comment component into answer box and past answer
- differentiate between all passed, some passed and none passed - give more information for how many test cases passed - fix all indentation and formatting error in BE code
- test for API call question_answer_details - and also all_answers
sm is also the MUI default, so other places using this component are not affected
individual live feedback histories need this information to be retrieved
syoopie
force-pushed
the
yupei/add-live-feedback-history
branch
from
August 28, 2024 09:11
2890644
to
6837a5b
Compare
syoopie
force-pushed
the
yupei/add-live-feedback-history
branch
from
August 28, 2024 09:53
c9eb16e
to
f940b47
Compare
syoopie
merged commit Aug 28, 2024
f940b47
into
yupei/add-live-feedback-storage-and-statistics
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add displaying of live feedback history from the statistics page. This is a continuation of #7497
UI referenced from #7135
Now clicking on the cell in the statistics page for live help will being up the histories of live help.
Note that history will only be shown when comments exist.