Timed Assessment: Timer starts only when user click "Start" while initiating Attempt #7548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
8 times, most recently
from
6c79d3b
to
181cb3b
Compare
cysjonathan
requested changes
Sep 12, 2024
client/app/bundles/course/assessment/submission/pages/SubmissionEditIndex/index.jsx
Outdated
Show resolved
Hide resolved
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
181cb3b
to
0e7b329
Compare
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
0e7b329
to
b9fceae
Compare
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
b9fceae
to
37f55ee
Compare
cysjonathan
requested changes
Nov 15, 2024
| return <div />; | ||
| }; | ||
|
|
||
| export default RemainingTimeTranslations; |
There was a problem hiding this comment.
Check filename RemainingTimeTranslation or RemainingTimeTranslations
| @@ -22,7 +22,7 @@ def perform_tracked(assessment, submission_id, submitter) | |||
| def force_submit(submission, submitter) | |||
| User.with_stamper(submitter) do | |||
| ActiveRecord::Base.transaction do | |||
| submission.update!('finalise' => 'true') | |||
| submission.update!('finalise' => 'true') if submission.attempting? | |||
There was a problem hiding this comment.
Nit: I find it cleaner to check for the workflow state attempting during the query in line 13, than the check here within the transaction itself.
| if (hours > 0) { | ||
| return ( | ||
| <FormattedMessage | ||
| {...translations.hoursMinutesSeconds} |
There was a problem hiding this comment.
Nit: can reduce the number of translations by using =0, you won't have so many if-cases as well.
See example:
| @@ -306,6 +306,13 @@ const SubmissionsTableRow = (props) => { | |||
| : null} | |||
| </TableCell> | |||
| ) : null} | |||
| {assessment.hasTimeLimit ? ( | |||
There was a problem hiding this comment.
instead of : null, why not
{assessment.hasTimeLimit && (
<TableCell style={tableCenterCellStyle}>
{submission.timerStartedAt && formatDate(submission.timerStartedAt)}
</TableCell>
)}| @@ -471,12 +477,20 @@ const translations = defineMessages({ | |||
| '{stillSomeTimeRemaining, select, true {Once the time is up, \ | |||
| the assessment will be automatically finalised.} other {Finalising the submission now!}}', | |||
| }, | |||
| timedAssessmentStartDialogMessage: { | |||
| id: 'course.assessment.submission.timedExamStartDialogMessage', | |||
| defaultMessage: 'Click to start the assessment and the timer', | |||
There was a problem hiding this comment.
Can simplify to: Start the timed assessment
| startTimedExamAssessmentFailed: { | ||
| id: 'course.assessment.submission.startTimedExamAssessmentFailed', | ||
| defaultMessage: | ||
| 'There is an error in starting the exam / assessment. Please check your \ |
There was a problem hiding this comment.
missing trailing full stop, and don't need to overload with both terminology "exam / assessment", can keep it short.
There was an error starting the assessment. Please check your internet connection and try again.
| timedExamDialogTitle: { | ||
| id: 'course.assessment.submission.timedExamDialogTitle', | ||
| defaultMessage: | ||
| '{stillSomeTimeRemaining, select, true {{remainingTime} {isNewSubmission, select, true {} other {remaining}} to \ | ||
| complete this exam.} other {The exam has ended!}}', | ||
| }, | ||
| timedExamStartDialogMessage: { | ||
| id: 'course.assessment.submission.timedExamStartDialogMessage', | ||
| defaultMessage: 'Click to start the exam and the timer', |
client/app/bundles/course/assessment/components/AssessmentForm/translations.ts
Outdated
Show resolved
Hide resolved
- timer starts only after student click "Start" when start attempting the exam
- if submission already has timer started at, we won't allow to re-configure it - add test cases regarding this API - refactor the TimeLimitBanner to accommodate when timer not started yet
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
37f55ee
to
b0c23f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.