Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add configurations for rails 7.2, ruby {3.2, 3.3} #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:
- master
schedule:
- cron: '0 0 * * 0'
workflow_dispatch:

permissions:
contents: read
Expand All @@ -25,12 +26,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.0', '3.1', '3.2']
activerecord: ['6.0', '6.1', '7.0', '7.1']
ruby-version: ['3.0', '3.1', '3.2', '3.3']
activerecord: ['7.0', '7.1', '7.2']
exclude:
- ruby-version: '3.0'
activerecord: '7.2'
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.activerecord }}.gemfile
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Ruby
# To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
# change this to (see https://github.com/ruby/setup-ruby#versioning):
Expand Down
15 changes: 5 additions & 10 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
appraise "rails-6.0" do
gem 'rails', '6.0.6.1'
gem 'rspec-rails', '~> 5'
end

appraise "rails-6.1" do
gem 'rails', '~> 6.1'
gem 'rspec-rails', '>= 6'
end

appraise "rails-7.0" do
gem 'rails', '7.0.8.4'
gem 'rspec-rails', '>= 6'
Expand All @@ -17,3 +7,8 @@ appraise "rails-7.1" do
gem 'rails', '~> 7.1'
gem 'rspec-rails', '>= 6'
end

appraise "rails-7.2" do
gem 'rails', '~> 7.2'
gem 'rspec-rails', '>= 6'
end
9 changes: 0 additions & 9 deletions gemfiles/rails_6.0.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails_6.1.gemfile → gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "coveralls_reborn", require: false
gem "rails", "~> 6.1"
gem "rails", "~> 7.2"
gem "rspec-rails", ">= 6"

gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/settings_on_rails/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module SettingsOnRails
VERSION = '0.4.0'
VERSION = '0.4.1'
end
4 changes: 2 additions & 2 deletions settings_on_rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require 'settings_on_rails/version'
Gem::Specification.new do |spec|
spec.name = 'settings_on_rails'
spec.version = SettingsOnRails::VERSION
spec.authors = ['Bivan Alzacky Harmanto']
spec.authors = ['Adi Suryanata Herwana', 'Allen Wang Qiang', 'Bivan Alzacky Harmanto']
spec.email = ['[email protected]']

spec.summary = %q{Model specific Hash Preferences/Settings for Rails.}
Expand All @@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.required_ruby_version = '>= 3'
spec.add_dependency 'rails', '>= 6'
spec.add_dependency 'rails', '>= 7'

spec.add_development_dependency 'sqlite3', '~> 1.7'
spec.add_development_dependency 'bundler', '>= 1.6'
Expand Down