Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support PHPUnit ^11.0 #6

Closed
wants to merge 1 commit into from
Closed

support PHPUnit ^11.0 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"require": {
"covergenius/php-vcr": "^1.7",
"php": "^8.1",
"phpunit/phpunit": "^10.4 | ^11"
"phpunit/phpunit": "^10.4||^11.0"
},
"scripts": {
"test": [
Expand Down
9 changes: 4 additions & 5 deletions tests/VCRTestListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

namespace Tests\VCR\PHPUnit\TestListener;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\TestCase;

final class VCRTestListenerTest extends TestCase
Expand All @@ -28,9 +30,8 @@ public function testInterceptsWithAnnotationsAndFileExtension(): void

/**
* @vcr unittest_annotation_test
*
* @dataProvider dummyDataProvider
*/
#[DataProvider('dummyDataProvider')]
public function testInterceptsWithAnnotationsWhenUsingDataProvider(int $dummyValue): void
{
// Content of tests/fixtures/unittest_annotation_test: "This is an annotation test dummy".
Expand All @@ -40,9 +41,7 @@ public function testInterceptsWithAnnotationsWhenUsingDataProvider(int $dummyVal
$this->assertEquals('This is a annotation test dummy.', $result, 'Call was not intercepted (using annotations with data provider).');
}

/**
* @group https://github.com/php-vcr/phpunit-testlistener-vcr/issues/29
*/
#[Group('https://github.com/php-vcr/phpunit-testlistener-vcr/issues/29')]
public function testNoVcrAnnotationRunsSuccessfulAndDoesNotProduceWarnings()
{
$this->assertTrue(true, 'just adding an assertion here');
Expand Down