Remove deprecated function usage #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring and add it as requirement in composer
|
Will also make the tag/release as 2.1.0 since it's potentially something breaking (though the composer should block an update to it), best to make it clear it does have some minor possibly breaking change. |
…sion to check for deprecated usage
|
I've also now added an extension for phpstan that will report deprecated functions to make sure we keep things upto date moving forward. It noted one from guzzle which I've updated as suggested by guzzle. |
girishl-cg
approved these changes
Nov 13, 2023
specialtactics
approved these changes
Nov 15, 2023
|
Looks good to me @sf-cg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8_encode is deprecated from PHP 8.2 onwards, so we'll remove it to get rid of warnings and be better prepared for future PHP releases.
It's replaced with mbstring, which I've added to composer as a requirement to make sure consumers will not pick up this version of the package if they will not be able to run the newly changed line.