fix(maxRetries): avoid chicken and egg problem when maxRetries is set to 0 for initial CR reconciles #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agill17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the use case when a user wants to install a CR with only 1 retry. This is done by setting maxRetries to 0. It works like backOffLimit in a k8s job.
Bug was, when spec.maxRetries is set to 0 and this is first reconcile, controller was checking the status failureCount number which by default is 0. So when both are 0, the controller would not reconcile the CR.
Every new reconcile for every new CR, the failureCount in status will always start with 0, so we need to exclude failureCount check when checking whether a CR maxRetries has been met.