Optional New Gene Data File Incorporation #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how optional new gene data files should be included in a new gene data subdirectory, in part to prepare for the introduction of new gene associated metabolic reactions in PR #1361. Knowing that optional data files (and their corresponding attributes) always exist will simplify the code, as noted by @1fish2 in a comment on PR #1361.
This change means that all optional new gene files should be included in every new gene data subdirectory. Flexibility is still maintained - if the user does not want to specify the data represented by that file, e.g. protein half-lives, then they can leave the contents of the file below its header blank. The template new gene data directory and new gene documentation have also been updated to reflect this change.