Cdonnellytx/chore/support dev on windows #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switching to cross-platform tooling (rimraf, shx) - Adding separate prebuild/postbuild tasks to handle clean, changelog.txt This allows commits to be done on any supported OS, including Windows, where they failed previously.
americk0
added
the
release/skip
americk0
requested review from
a team,
DevOpsDave,
codykoelemay and
LumaC0
and removed request for
a team
|
After opening this PR the original PR magically got access to the secrets it needed to pass the build checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log Items
Description
This allows commits to be done on any supported OS, including Windows, where they failed previously.
Rally: N/A
Note: I couldn't figure out how to get the necessary github actions build checks to run with access to repository secrets since this PR originally came from a fork, so this is me re-opening the PR directly on the repo to get checks to execute with the necessary secrets. I really wish github gave me a way to do just run the workflows with secrets at the click of a button after I review the PR and deem it safe, but no such functionality exists so here we are
closes #270