Merge pull request #69 from Cox-Automotive/fix-get-login-role

Fix get login role
Cox-Automotive · Apr 20, 2021 · b8ef7da · b8ef7da
2 parents da8e772 + 7d0b339
commit b8ef7da
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 17 deletions.
diff --git a/dist/alks.cjs.js b/dist/alks.cjs.js
@@ -719,7 +719,6 @@ class alks {
    * @param {Object} props - An object containing the following properties
    * @param {string} props.accountId - The 12-digit account ID associated with the custom role
    * @param {string} props.role - The user's role associated with the account
-   * @param {number} props.maxKeyDuration - The maximum key duration for this account
    * @returns {Promise<Object>}
    * @example
    * alks.getLoginRole({
@@ -730,8 +729,8 @@ class alks {
    */
   getLoginRole(props) {
     const {accountId, role} = props;
-    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null).then((results) =>
-      pick(results, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
+    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null, 'GET').then((results) =>
+      pick(results.loginRole, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
   }
 
   /**

diff --git a/dist/alks.esm.js b/dist/alks.esm.js
@@ -716,7 +716,6 @@ class alks {
    * @param {Object} props - An object containing the following properties
    * @param {string} props.accountId - The 12-digit account ID associated with the custom role
    * @param {string} props.role - The user's role associated with the account
-   * @param {number} props.maxKeyDuration - The maximum key duration for this account
    * @returns {Promise<Object>}
    * @example
    * alks.getLoginRole({
@@ -727,8 +726,8 @@ class alks {
    */
   getLoginRole(props) {
     const {accountId, role} = props;
-    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null).then((results) =>
-      pick(results, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
+    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null, 'GET').then((results) =>
+      pick(results.loginRole, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
   }
 
   /**

diff --git a/dist/alks.min.js b/dist/alks.min.js
diff --git a/dist/alks.umd.js b/dist/alks.umd.js
@@ -713,7 +713,6 @@
    * @param {Object} props - An object containing the following properties
    * @param {string} props.accountId - The 12-digit account ID associated with the custom role
    * @param {string} props.role - The user's role associated with the account
-   * @param {number} props.maxKeyDuration - The maximum key duration for this account
    * @returns {Promise<Object>}
    * @example
    * alks.getLoginRole({
@@ -725,7 +724,7 @@
   alks.prototype.getLoginRole = function getLoginRole (props) {
     var accountId = props.accountId;
       var role = props.role;
-    return this._doFetch(("loginRoles/id/" + accountId + "/" + role), null).then(function (results) { return pick(results, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']); })
+    return this._doFetch(("loginRoles/id/" + accountId + "/" + role), null, 'GET').then(function (results) { return pick(results.loginRole, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']); })
   };
 
   /**

diff --git a/index.d.ts b/index.d.ts
@@ -185,7 +185,6 @@ declare namespace ALKS {
   export interface GetLoginRoleProps {
     accountId: string;
     role: string;
-    maxKeyDuration: number;
   }
 
   export interface GetAccessTokenProps extends Partial<AlksProps> {

diff --git a/src/alks.js b/src/alks.js
@@ -718,7 +718,6 @@ class alks {
    * @param {Object} props - An object containing the following properties
    * @param {string} props.accountId - The 12-digit account ID associated with the custom role
    * @param {string} props.role - The user's role associated with the account
-   * @param {number} props.maxKeyDuration - The maximum key duration for this account
    * @returns {Promise<Object>}
    * @example
    * alks.getLoginRole({
@@ -729,8 +728,8 @@ class alks {
    */
   getLoginRole(props) {
     const {accountId, role} = props
-    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null).then((results) =>
-      pick(results, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
+    return this._doFetch(`loginRoles/id/${accountId}/${role}`, null, 'GET').then((results) =>
+      pick(results.loginRole, ['account', 'role', 'iamKeyActive', 'maxKeyDuration']))
   }
 
   /**

diff --git a/test/test.js b/test/test.js
@@ -716,10 +716,12 @@ describe('alks.js', function() {
 
       const _fetch = fetchMock.sandbox().mock(`${baseUrl}/loginRoles/id/${accountId}/${role}`, {
         body: {
-          account,
-          role,
-          iamKeyActive,
-          maxKeyDuration
+          loginRole: {
+            account,
+            role,
+            iamKeyActive,
+            maxKeyDuration
+          }
         },
         status: 200
       })