Make AlksError extend Error

Cox-Automotive · Jan 15, 2019 · bb242d7 · bb242d7
1 parent 911ba53
commit bb242d7
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 20 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -6,8 +6,7 @@
         "mocha": true
     },
     "parserOptions": {
-        "sourceType": "module",
-        "ecmaVersion": 2018
+        "sourceType": "module"
     },
     "extends": "eslint:recommended",
     "rules": {

diff --git a/dist/alks.js b/dist/alks.js
@@ -95,10 +95,17 @@ var alks = (function () {
     })
   };
   var pick = function (obj, props) { return props.reduce(function (a, e) { return (a[e] = obj[e], a); }, {}); };
-  var AlksError = function (response, json) { return (Object.assign({}, {name: 'AlksError',
-    message: response.statusText,
-    status: response.status},
-    json)); };
+  var AlksError = (function (Error) {
+    function AlksError(response, json) {
+      Error.call(this, response.statusText);
+      this.status = response.status;
+      Object.assign(this, json);
+    }
+    if ( Error ) AlksError.__proto__ = Error;
+    AlksError.prototype = Object.create( Error && Error.prototype );
+    AlksError.prototype.constructor = AlksError;
+    return AlksError;
+  }(Error));
   var alks$1 = new alks();
 
   return alks$1;

diff --git a/dist/alks.min.js b/dist/alks.min.js
diff --git a/lib/alks.node.js b/lib/alks.node.js
@@ -419,12 +419,13 @@ class alks {
 
 const pick = (obj, props) => props.reduce((a, e) => (a[e] = obj[e], a), {});
 
-const AlksError = (response, json) => ({
-  name: 'AlksError',
-  message: response.statusText,
-  status: response.status,
-  ...json
-});
+class AlksError extends Error {
+  constructor(response, json) {
+    super(response.statusText);
+    this.status = response.status;
+    Object.assign(this, json);
+  }
+}
 
 var alks$1 = new alks();
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "alks.js",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "JavaScript client for the ALKS API, usable in both modern browsers and node.js",
   "main": "lib/alks.node.js",
   "scripts": {

diff --git a/src/alks.js b/src/alks.js
@@ -417,11 +417,12 @@ class alks {
 
 const pick = (obj, props) => props.reduce((a, e) => (a[e] = obj[e], a), {})
 
-const AlksError = (response, json) => ({
-  name: 'AlksError',
-  message: response.statusText,
-  status: response.status,
-  ...json
-})
+class AlksError extends Error {
+  constructor(response, json) {
+    super(response.statusText)
+    this.status = response.status
+    Object.assign(this, json)
+  }
+}
 
 export default new alks()