update aruba ansible playbook CASMNET-2026 (#256)

* Fix unchecked `bmc` port `3` error, enhance messaging and begin model refactoring. * version bump * correct misspelling * CASMNET-1968 add dynamic ansible inventory script that queries SLS Signed-off-by: Jacob Salmela <[email protected]> * CASMNET-1982 ansible plays for aruba Signed-off-by: Jacob Salmela <[email protected]> * Update readme Signed-off-by: Jacob Salmela <[email protected]> * CASMNET-1968 and CASMNET-1982 tests Signed-off-by: Jacob Salmela <[email protected]> * update spec to install canu-inventory Signed-off-by: Jacob Salmela <[email protected]> * pyinstaller changes to deploy canu and canu-inventory Signed-off-by: Jacob Salmela <[email protected]> * remove snooper Signed-off-by: Jacob Salmela <[email protected]> * fix lint for shcd.py Signed-off-by: Jacob Salmela <[email protected]> * use variable for leaf bmc play Signed-off-by: Jacob Salmela <[email protected]> * allow ansible to apply configs to all switches, remove banner munging * add lnet onboard * update aruba ansible playbook * readme * revert template changes from other branch * Update README.md Signed-off-by: lukebates123 <[email protected]> * pull mgmt interface from api * check for config differences before applying config to running * comments * readme Signed-off-by: Jacob Salmela <[email protected]> Signed-off-by: lukebates123 <[email protected]> Signed-off-by: Russell Bunch <[email protected]> Co-authored-by: Sean Lynn <[email protected]> Co-authored-by: Jacob Salmela <[email protected]> Co-authored-by: lukebates123 <[email protected]> Co-authored-by: Russell Bunch <[email protected]>
Cray-HPE · Jan 26, 2023 · 204abf3 · 204abf3
1 parent 47e8d37
commit 204abf3
Show file tree

Hide file tree

Showing 2 changed files with 109 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# 🛶 CANU v1.6.31
+# 🛶 CANU v1.6.32
 
 CANU (CSM Automatic Network Utility) will float through a Shasta network and make switch setup and validation a breeze.
 
@@ -1317,10 +1317,22 @@ Version      : GL.10.09.0010
 
 `canu-inventory` is a dynamic inventory script that queries a `sls_input_file.json` in the working directory, or an API gateway (`$SLS_API_GW`).  It can be called directly to print the information or it can be passed as an argument to `ansible-inventory`.
 
+- `$SLS_API_GW` and `$SLS_TOKEN` (or `$TOKEN`) must be set in order to query the API.
+- `$SWITCH_USERNAME` and `$SWITCH_PASSWORD` must be set in order to execute playbooks.
+- `ANSIBLE_HOST_KEY_CHECKING=False` can be set to ignore host key checking.
+- `-e config_folder` should be set to the directory containing the switch configs.
+
 ```bash
 # examples
 ansible-inventory -i canu-inventory --list
-ansible-playbook -i canu-inventory my_play.yml # set hosts in the playbook
+ansible-playbook -i canu-inventory aruba-aoscx.yml -e config_folder=/switch_configs
+```
+
+When running the playbook you may need to input the full path to `canu-inventory`, the playbook, and the switch configs.
+
+```bash
+# example
+ansible-playbook -i /Users/bin/canu-inventory /Users/bin/canu/inventory/plays/aruba-aoscx.yml -e config_folder=/Users/canu
 ```
 
 If using the API, `$TOKEN` or `$SLS_TOKEN` need to be set.
@@ -1365,6 +1377,12 @@ To reuse a session without reinstalling dependencies use the `-rs` flag instead
 
 # Changelog
 
+## [1.6.32]
+
+- Updated Aruba ansible playbook and documentation.
+- Added ansible play to retain mgmt interface configuration.  This will help avoid lockouts.
+- Added ansible play utilize the aruba checkpoint feature.  This will revert the switch config after 1 minute if the switch becomes unresponsive. 
+
 ## [1.6.31]
 
 - Modify nmn-hmn ACL to block traffic between the NMNLB and HMNLB networks.

diff --git a/canu/inventory/plays/aruba-aoscx.yml b/canu/inventory/plays/aruba-aoscx.yml
@@ -8,18 +8,16 @@
     # pass in the folder containing the switch configs or be in the same directory
     config_folder: ""
     switch_config: "{{ config_folder }}/{{ inventory_hostname }}.cfg"
-    login_url: "https://{{ ansible_host }}/rest/v1/login"
-    dryrun_url: "https://{{ ansible_host }}/rest/v1/configs/running-config?dryrun"
+    login_url: "https://{{ ansible_host }}/rest/v10.09/login"
+    dryrun_url: "https://{{ ansible_host }}/rest/v10.09/configs/running-config?dryrun"
     checkpoint_name: "ac_{{ ansible_date_time.year }}_{{ ansible_date_time.month }}_{{ ansible_date_time.day }}_{{ansible_date_time.hour }}_{{ ansible_date_time.minute }}_{{ ansible_date_time.second }}"
-    checkpoint_url: "https://{{ ansible_host }}/rest/v1/fullconfigs/{{ checkpoint_name }}?from=/rest/v1/fullconfigs/running-config"
-    configs_url: "https://{{ ansible_host }}/rest/v1/fullconfigs"
-    munged_banner: "Adjusted by Ansible for checkpoint: {{ checkpoint_name }}"
-    pseudo_checkpoint_url: "https://{{ ansible_host }}/rest/v1/fullconfigs/{{ checkpoint_name }}"
+    configs_url: "https://{{ ansible_host }}/rest/v10.09/fullconfigs"
     validated_config_json: "{{ playbook_dir }}/{{ inventory_hostname }}_{{ checkpoint_name }}.json"
-    logout_url: "https://{{ ansible_host }}/rest/v1/logout"
+    logout_url: "https://{{ ansible_host }}/rest/v10.09/logout"
+    running_config_url: "https://{{ ansible_host }}/rest/v10.09/configs/running-config"
   tasks:
     - name: get running config as json
-      arubanetworks.aoscx.aoscx_backup_config:
+      aoscx_backup_config:
         config_name: "running-config"
         output_file: "{{ inventory_hostname }}.json"
 
@@ -83,26 +81,99 @@
           when: _result.json.state == "error"
           failed_when: _result.json.state == "error"
 
-        # Begin munging operations
-        # Per the aruba docs, it's not possible to have two checkpoints with the same configuration
-        # Thus, a checkpoint with this exact JSON cannot be used as a new checkpoint or it is detected as a duplicate
-        # As a workaround, one semi-harmless key is modified--the banner
-        # Changing this makes the config different from the running config without any operational side-effects
-        - name: begin munging by setting facts using the existing config
+        - name: get generated config in json format
           ansible.builtin.set_fact:
             original_config: "{{ _result.json.configs.json }}"
 
-        # # TODO: Technically, we should do another dry run here to validate there is no garbage in the config
+        # Get the mgmt interface config from the running-config and apply it to the generated config.
+        # This should prevent users from accidentally locking themselves out.
+        # We can't get query the API direclty for the mgmt interface config because
+        # there are additional fields added that won't work when we upload the running-config json payload.
+        - name: get mgmt int config from running config
+          ansible.builtin.uri:
+            url: "{{ running_config_url }}"
+            validate_certs: false
+            use_proxy: false
+            method: GET
+            return_content: true
+            headers:
+              Cookie: "{{ login.set_cookie }}"
+          register: running_config_data
+
+        - name: get mgmt int json
+          ansible.builtin.set_fact:
+            mgmt_int: "{{ running_config_data.json.System.mgmt_intf }}"
+
+        - name: add mgmt int config to generated config
+          ansible.utils.update_fact:
+            updates:
+              - path: original_config.System.mgmt_intf
+                value: "{{ mgmt_int }}"
+          register: updated_config
+
         - name: write jsonified config to a local file
           ansible.builtin.copy:
-            content: "{{ original_config | to_json(indent=4) }}"
+            content: "{{ updated_config.original_config | to_json(indent=4) }}"
             dest: "{{ validated_config_json }}"
 
+        # set checkpoint for 1 minute.
+        # This play uses ssh instead of the default api.
+        - name: set checkpoint for one minute "checkpoint auto 1"
+          vars:
+            ansible_connection: network_cli
+          aoscx_command:
+            commands:
+              - checkpoint auto confirm # accept lingering checkpoints, ran into issues after uploadding full json conifg
+              - checkpoint auto 1
+
         # Finally, upload the new config as the running-config
-        - name: upload local json config to the running-config
+        - name: upload local json config to the startup-config
           aoscx_upload_config:
-            config_name: "running-config"
+            config_name: "startup-config"
             config_json: "{{ validated_config_json }}"
+            vrf: "mgmt"
+          timeout: 15
+
+        - name: get diff between running-config and startup-config
+          register: diff
+          vars:
+            ansible_connection: network_cli
+          aoscx_command:
+            commands:
+              - checkpoint diff startup-config running-config
+
+        # print cli diff output
+        - name: diff output
+          debug:
+            msg: "{{ item }}"
+          with_items: "{{ diff['stdout'] }}"
+
+        # copy startup-config to running-config if there are changes needed.
+        - name: Copy startup-config to running-config
+          aoscx_checkpoint:
+            destination_config: running-config
+            source_config: startup-config
+          timeout: 15
+          when: diff.stdout[0] != "No difference in configs."
+
+        # Accept the checkpoint
+        - name: confirm checkpoint "checkpoint auto confirm"
+          vars:
+            ansible_connection: network_cli
+          aoscx_command:
+            commands:
+              - checkpoint auto confirm
+          retries: 5
+          delay: 5 # Every 5 seconds
+
+        # Save the config.  Shouldn't need this but just incase.
+        - name: Save the configuration "write memory"
+          vars:
+            ansible_connection: network_cli
+          aoscx_command:
+            commands:
+              - write memory
+          when: diff.stdout[0] != "No difference in configs."
 
       # always log out so no session is left open
       always: