Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker image cannot run owing to nornir 3.1.1 / dataclasses 0.8 incompatibility #78

Closed
dmjacobsen opened this issue Jan 26, 2022 · 3 comments
Closed

docker image cannot run owing to nornir 3.1.1 / dataclasses 0.8 incompatibility #78

dmjacobsen opened this issue Jan 26, 2022 · 3 comments
Assignees
@trad511 @lukebates123
Labels
bug Something isn't working

Comments

@dmjacobsen
Copy link

Describe the bug
Cannot start canu with no arguments in a docker container built on the develop or release-1.1.4 branch. The program generates a pair of exceptions indicating an incompatbility between nornir and dataclasses.

canu Version
Found this on the develop and release-1.1.4 branches. Did not try other branches. Bug prevents program from running, so did not attempt canu --version.

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://....
  2. git checkout develop
  3. docker build -t canu .
  4. docker run -it canu /bin/bash
  5. canu

Then you'll see the errors.

Expected behavior
Not crashing and failing and spewing errors.
@dmjacobsen dmjacobsen added the bug Something isn't working label Jan 26, 2022
@dmjacobsen
Copy link
Author

I found that by adding:

dataclasses==0.7

to the top of requirements.txt and rebuilding the container, that canu can then run (with no arguments) without error.

dmjacobsen added a commit to dmjacobsen/canu that referenced this issue Jan 26, 2022
@dmjacobsen
Fix conflict between nornir and dataclasses
ef849e6 
dataclasses 0.8 is getting pulled in implicitly by ... something ... in the context of a docker build.  This causes the program to not operate correctly as reported in Cray-HPE#78.  One possible fix is to simply constrain the version of dataclasses to 0.7 to prevent this anomalous behavior, another would be to identify what is pulling in dataclasses and address it more explicitly elsewhere.  Being unfamiliar with this package, I've chosen the former.
@dmjacobsen dmjacobsen mentioned this issue Jan 26, 2022
Closed
7 tasks
@gbaker-hpe
Copy link
Contributor

Thanks @dmjacobsen. I spoke with Luke and Sean and they're both going to try to repro this.

rustydb pushed a commit to dmjacobsen/canu that referenced this issue May 27, 2022
@dmjacobsen @rustydb
Fix conflict between nornir and dataclasses
4f7fd8a 
dataclasses 0.8 is getting pulled in implicitly by ... something ... in the context of a docker build.  This causes the program to not operate correctly as reported in Cray-HPE#78.  One possible fix is to simply constrain the version of dataclasses to 0.7 to prevent this anomalous behavior, another would be to identify what is pulling in dataclasses and address it more explicitly elsewhere.  Being unfamiliar with this package, I've chosen the former.
@rustydb
Copy link
Contributor

rustydb commented Jun 30, 2022

I think this can be closed, @dmjacobsen if you see this issue off the current develop branch (1.6.5) please re-open.

@rustydb rustydb closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trad511 trad511

@lukebates123 lukebates123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conflict between nornir and dataclasses dmjacobsen/canu
5 participants
@dmjacobsen @trad511 @rustydb @lukebates123 @gbaker-hpe