Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict between nornir and dataclasses #79

Closed
wants to merge 1 commit into from

Conversation

dmjacobsen
Copy link

@dmjacobsen dmjacobsen commented Jan 26, 2022

dataclasses 0.8 is getting pulled in implicitly by ... something ... in the context of a docker build. This causes the program to not operate correctly as reported in #78. One possible fix is to simply constrain the version of dataclasses to 0.7 to prevent this anomalous behavior, another would be to identify what is pulling in dataclasses and address it more explicitly elsewhere. Being unfamiliar with this package, I've chosen the former.

Summary and Scope

Description: What does this change do? Use examples of new options and output changes when possible. If other changes were made list these as well in a list.

PR checklist (you may replace this section):

  • I have run nox locally and all tests, linting, and code coverage pass.
  • I have added new tests to cover the new code
  • My code follows the style guidelines of this project
  • If adding a new file, I have updated pyinstaller.py
  • I have updated the appropriate Changelog entries in readme.md
  • I have incremented the version in the readme.md
  • I have incremented the version in canu/.version

Issues and Related PRs

Potentially resolves #78

Testing

Tested on:

  • modified buildah/podman instance of Dockerfile (will file issue on that separately) on the alvarez management VM.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@trad511
Copy link
Collaborator

trad511 commented Feb 3, 2022

Haven't left this behind. Looking at this in conjunction with the WIP 44 branch to reconstruct the setup.py build.

dataclasses 0.8 is getting pulled in implicitly by ... something ... in the context of a docker build.  This causes the program to not operate correctly as reported in Cray-HPE#78.  One possible fix is to simply constrain the version of dataclasses to 0.7 to prevent this anomalous behavior, another would be to identify what is pulling in dataclasses and address it more explicitly elsewhere.  Being unfamiliar with this package, I've chosen the former.
@rustydb rustydb force-pushed the dmjacobsen-patch-1 branch from ef849e6 to 4f7fd8a Compare May 27, 2022 07:20
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
34.9% 34.9% Duplication

@rustydb
Copy link
Contributor

rustydb commented May 27, 2022

The unittests should've finished.. they're stuck.
The branch build won't run because this is a fork.

@rustydb
Copy link
Contributor

rustydb commented May 27, 2022

When I look in the current build output I don't see this package brought in, neither in main nor develop.

@rustydb rustydb closed this May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image cannot run owing to nornir 3.1.1 / dataclasses 0.8 incompatibility
4 participants