Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.6.27 #236

Merged
merged 94 commits into from
Nov 17, 2022
Merged

Release 1.6.27 #236

merged 94 commits into from
Nov 17, 2022

Conversation

trad511
Copy link
Collaborator

@trad511 trad511 commented Nov 17, 2022 •
edited
Loading

Summary and Scope

Overview:

  • CANU versioning management and the build pipeline has been entirely reworked. End-users should experience no change, but behind the scenes this helps tremendously.
  • A unnecessary Control Plane ACL, previously removed for other CSM versions was removed for CSM 1.2.
  • CAN port configurations are now removed from switch ports if the CHN is enabled.
  • canu validate shcd-cabling and canu validate paddle-cabling have been fixed to better handle incoming LLDP data. This required enhancement of the CANU internal network model.
  • Output of many commands has been cleaned up and better next-step guidance added when errors are found.

Details:

  • Fix the CANU model to allow "cable swapping" while using LLDP data.
  • Update generated docs from template changes.
  • Fix sls_utils so that it works correctly when using a SLS.json file.
  • Shutdown UAN CAN port when CHN is enabled.
  • Remove Control Plane ACL for CSM 1.2 previously missed.
  • Update Arista BGP templates.
  • Add feature flag for CHN BGP control plane.
  • Fix ordering of switch configuration when using custom switch configs or --reorder.
  • Node types and model lookups:
    • Fix login node Shasta name for v1 architecture.
    • Added gpu and kvm node definitions to v1 architecture.
    • Add gpu node definitions to v2 TDS architecture.
  • Messaging and Error cleanup:
    • Added logging to canu generate switch/network config to clean up output.
    • Provided better messaging about next-step handling of missing configs in generated files.
    • Provide better guidance during SHCD validation if port re-use/change is attempted.

rustydb and others added 30 commits October 14, 2022 14:23
@rustydb
Fixes #44 and #182 Build Once and Use Git-Tags
f148f40 
This removes the `.version` files and uses git-tags. `canu` now versions
itself within `setup.py` based on `git describe --tags`.

This also builds canu inside of the RPM `specfile` using `pyinstaller`
and no longer uses a special `pyinstaller` image.

The spec file will create a `canu` user.

All of the `requirements` files were converted into `setup.py`, this
tidies up the repository by using less files.

All references to the `.version` files were replaced by leveraging the
`pkg_resources` module to fetch the version from the module `PKG_INFO`.

This also breaks apart the GitHub actions for lint, docs, and tests into
their own workflows allowing for more parallelization.

Lastly this adds an automated, weekly dependabot scan for making PRs to
update dependencies.
@trad511
Fixes #44 and #182 Build Once and Remove .version (#184)
819c745
@dependabot
Bump jinja2 from 3.0.2 to 3.1.2
6353348 
Bumps [jinja2](https://github.com/pallets/jinja) from 3.0.2 to 3.1.2.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.0.2...3.1.2)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump openpyxl from 3.0.9 to 3.0.10
295e5d1 
Bumps [openpyxl](https://openpyxl.readthedocs.io) from 3.0.9 to 3.0.10.

---
updated-dependencies:
- dependency-name: openpyxl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@trad511
Squish original CAMSNET-1896 branch commits
8a90793
@lukebates123
fix canu version
c0f840d
@trad511
CASMNET-1896 (#209)
fa0f57a
@trad511
Remove control-plane acl for Customer VRF in 1.2
971397e 
Fix tests

bump version
@trad511
bump version
3dccc5b
@trad511
Fix tests lost in rebase.
b94cf9a
@trad511
CASMNET-1901 - Remove control-plane acl for Customer VRF in CSM1.2 (#210
a1dc9a6 
)
@lukebates123 @trad511
fix uan port for UAN
f8ca9e9
@trad511
bump version
320674b
@trad511
CASMNET-1910 (#211)
4c026e9
@lukebates123 @trad511
fix json input in canu backup
5c7a04c
@lukebates123 @trad511
fix nornir inventory
fa90918
@trad511
bump version
7848480
@lukebates123
lint
cc435a3
@trad511
CASMNET-1912 (#212)
a3d3822
@trad511
Merge branch 'develop' into dependabot/pip/openpyxl-3.0.10
27165ff
@trad511
Bump openpyxl from 3.0.9 to 3.0.10 (#217)
e613ffe
@trad511
Merge branch 'develop' into dependabot/pip/jinja2-3.1.2
555bfbb
@dependabot
Bump pyyaml from 5.4.1 to 6.0
1c2812b 
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.4.1 to 6.0.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.4.1...6.0)

---
updated-dependencies:
- dependency-name: pyyaml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@trad511
Bump jinja2 from 3.0.2 to 3.1.2 (#216)
0e014e8
@trad511
Merge branch 'develop' into dependabot/pip/pyyaml-6.0
e91e4a7
@dependabot
Bump nornir-scrapli from 2022.1.30 to 2022.7.30
61f4c96 
Bumps [nornir-scrapli](https://github.com/scrapli/nornir_scrapli) from 2022.1.30 to 2022.7.30.
- [Release notes](https://github.com/scrapli/nornir_scrapli/releases)
- [Commits](scrapli/nornir_scrapli@2022.01.30...2022.07.30)

---
updated-dependencies:
- dependency-name: nornir-scrapli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@trad511
Bump pyyaml from 5.4.1 to 6.0 (#214)
848db14
@trad511
Merge branch 'develop' into dependabot/pip/nornir-scrapli-2022.7.30
43f12bd
@trad511
Bump nornir-scrapli from 2022.1.30 to 2022.7.30 (#218)
9c966be
@dependabot
Bump kubernetes from 20.13.0 to 24.2.0
0a2b6d7 
Bumps [kubernetes](https://github.com/kubernetes-client/python) from 20.13.0 to 24.2.0.
- [Release notes](https://github.com/kubernetes-client/python/releases)
- [Changelog](https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md)
- [Commits](kubernetes-client/python@v20.13.0...v24.2.0)

---
updated-dependencies:
- dependency-name: kubernetes
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
lukebates123 and others added 19 commits November 8, 2022 13:40
@lukebates123
bump lib versions
847f26e
@lukebates123
Merge branch 'develop' into CASMNET-1941
5273856
@trad511
bump lib versions (#233)
9646205
@lukebates123
Merge branch 'develop' into dependabot/pip/netutils-1.2.0
2d02926 
Signed-off-by: lukebates123 <[email protected]>
@lukebates123
Merge branch 'develop' into dependabot/pip/nornir-salt-0.16.1
768c417 
Signed-off-by: lukebates123 <[email protected]>
@lukebates123
Merge branch 'develop' into dependabot/pip/ruamel-yaml-lt-0.17.22
4fba166 
Signed-off-by: lukebates123 <[email protected]>
@trad511
Bump netutils from 1.0.0 to 1.2.0 (#225)
1ecc502
@trad511
Merge branch 'develop' into dependabot/pip/emoji-2.1.0
3e19341
@trad511
Bump emoji from 1.6.0 to 2.1.0 (#224)
656a6a4
@lukebates123
Update setup.py
f740713 
Signed-off-by: lukebates123 <[email protected]>
@lukebates123
Merge branch 'develop' into dependabot/pip/ruamel-yaml-lt-0.17.22
d01c088 
Signed-off-by: lukebates123 <[email protected]>
@lukebates123
Merge branch 'develop' into dependabot/pip/nornir-salt-0.16.1
45afb6a 
Signed-off-by: lukebates123 <[email protected]>
@trad511
Update ruamel-yaml requirement from <=0.16.13 to <0.17.22 (#223)
00b1b13
@trad511
Merge branch 'develop' into dependabot/pip/nornir-salt-0.16.1
3bf440e
@trad511
Bump nornir-salt from 0.9.0 to 0.16.1 (#222)
f9f2e5a
@rustydb
Updating template for Jenkinsfile
342becb
@rustydb
Updating template for Jenkinsfile (#234)
7807f61
@rustydb
Minor update to support Snyk scanning
0f069a6 
If Snyk scanning is ever added, then `setup.py` will be referred to in
an isolated environment for dependnecy scanning that does not contain
`PKG-INFO` (or `.git/` for that matter). Snyk will fail when invoking
`get_version()` unless it reesolves the version from the already
installed `canu` app.
@trad511
Minor update to support Snyk scanning (#235)
f7df1cf
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.7% 14.7% Duplication

@trad511 trad511 marked this pull request as ready for review November 17, 2022 17:46
@trad511 trad511 requested a review from a team as a code owner November 17, 2022 17:46
@trad511 trad511 changed the title Release 1.6.26 Release 1.6.27 Nov 17, 2022
@rustydb
Copy link
Contributor

rustydb commented Nov 17, 2022

Wait for #237 , it's coming in hot/shortly!

@trad511 trad511 merged commit 43ea79b into main Nov 17, 2022
lukebates123 pushed a commit that referenced this pull request Apr 8, 2024
@trad511
Release 1.6.27 (#236)
0177cf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosonenj kosonenj kosonenj approved these changes

@lukebates123 lukebates123 lukebates123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trad511 @rustydb @kosonenj @lukebates123