Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #237 #238

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Nov 17, 2022

Summary and Scope

Description:

Fixes local dev environments including necessary data files when installing canu, where without the files certain commands will produce a traceback. This wasn't exhibited on a system with the canu RPM installed because these data files were called out in pyinstaller.py, pyinstaller.py` isn't invoked in local dev environments.

I verified this works by invoking commands locally and via a feature RPM install.

Local Install

canu, version 1.6.20.post95
canu validate shcd -a V1 --shcd Cray\ Inc-Shasta\ RiverSystemForServiceTraining_SHCD_RevA8.xlsx --tabs 40G_10G,NMN,HMN --corners J28,T54,J15,T31,J20,U58 --json

System/RPM Install:

redbull-ncn-m001-pit:/var/www/ephemeral/prep # canu --version
canu, version 1.6.20.post95
redbull-ncn-m001-pit:/var/www/ephemeral/prep # canu validate shcd -a v1 --shcd ./Shasta\ River\ Redbull\ CCD_RevA10.xlsx --tabs 40G_10G,NMN,HMN --corners I12,S39,I9,S20,I20,S31 --json --out ccj.json

PR checklist (you may replace this section):

  • I have run nox locally and all tests, linting, and code coverage pass
  • I have added new tests to cover the new code
  • My code follows the style guidelines of this project
  • If adding a new file, I have updated pyinstaller.py
  • I have updated the appropriate Changelog entries in README.md
  • I have incremented the version in the README.md

Issues and Related PRs

  • Resolves: Issue
  • Relates to: Issue
  • Requires: Issue

Testing

Tested on:

@rustydb rustydb requested a review from a team as a code owner November 17, 2022 18:21
@rustydb rustydb linked an issue Nov 17, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rustydb rustydb merged commit 0931350 into develop Nov 17, 2022
@rustydb rustydb deleted the 237-traceback-when-invoking-canu-in-a-local-env branch November 17, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback when invoking `canu` in a local env
2 participants