CASMINST-6602 - enable dkms by default. #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
There was a request by cos to have the require-dkms default to 'true' instead of 'false' like it originally released. This changes the defaults and had to modify the logic a little bit to get it right for integrating with the 'require_dkms' flag in the recipe records.
Issues and Related PRs
Testing
Tested on:
Mug
Test description:
I deployed the new helm chart to ensure the correct default value is applied to the ims-config settings. I then tested each combination of global and per record settings to make sure the correct use of dkms was determined in each scenario.
Risks and Mitigations
Fairly low risk and there are workarounds if the default settings are not what the user wants.
Pull Request Checklist