Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMINST-6602 - enable dkms by default. #138

Merged
merged 2 commits into from
Aug 29, 2024
Merged

CASMINST-6602 - enable dkms by default. #138

merged 2 commits into from
Aug 29, 2024

Conversation

dlaine-hpe
Copy link
Contributor

Summary and Scope

There was a request by cos to have the require-dkms default to 'true' instead of 'false' like it originally released. This changes the defaults and had to modify the logic a little bit to get it right for integrating with the 'require_dkms' flag in the recipe records.

Issues and Related PRs

Testing

Tested on:

  • Mug

Test description:

I deployed the new helm chart to ensure the correct default value is applied to the ims-config settings. I then tested each combination of global and per record settings to make sure the correct use of dkms was determined in each scenario.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
  • Were continuous integration tests run? If not, why? N
  • Was upgrade tested? If not, why? Y
  • Was downgrade tested? If not, why? Y
  • Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations

Fairly low risk and there are workarounds if the default settings are not what the user wants.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@dlaine-hpe dlaine-hpe requested a review from a team as a code owner August 29, 2024 01:06
@dlaine-hpe dlaine-hpe merged commit 101c1f0 into develop Aug 29, 2024
4 checks passed
@dlaine-hpe dlaine-hpe deleted the CASMINST-6602 branch August 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants