Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-7327 - fix reading default values from ims-config. #146

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dlaine-hpe
Copy link
Contributor

Summary and Scope

This wraps 3 changes into one PR:
CASMTRIAGE-7327 - Fix picking up the correct defaults from the ims-config configmap.
CASMTRIAGE-7274 - Fix the cpu limits for the containers to not overdrive the kata VM.
CASMCMS-9147 - Stop using alpine:latest - switch to the CSM rebuilt version.

Issues and Related PRs

Testing

Tested on:

  • Mug, Tyr, Fanta, Gamora

Test description:

I have installed the package via helm on Mug to insure the upgrade/downgrade worked correctly and tested changing the ims-config settings and verified they flowed through to the job settings as they should. This also verified the alpine base image change. The cpu limits were tested on a whole bunch of different systems as problems were encountered.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
  • Were continuous integration tests run? If not, why? N
  • Was upgrade tested? If not, why? Y
  • Was downgrade tested? If not, why? Y
  • Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations

Fairly low risk changes - just tweaks to settings for the most part that have been tested.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@dlaine-hpe dlaine-hpe requested a review from a team as a code owner October 2, 2024 14:44
Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlaine-hpe dlaine-hpe merged commit bc16a2c into develop Oct 3, 2024
4 checks passed
@dlaine-hpe dlaine-hpe deleted the CASMTRIAGE-7327 branch October 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants