Skip to content

Commit

Permalink
Patch Changes for Release Prep (#477)
Browse files Browse the repository at this point in the history
This PR makes several patch changes to prepare for a SmartSim release
including:

- Set the default value of the "enable telemetry" flag to on.
Currently this will enable telemetry system wide until finer grain
control can be established with #460
- Bump the output `manifest.json` version number to match that of
`smartdashboard`
- Pin a watchdog version to avoid build errors


[ committed by @MattToast @ankona ]
[ reviewed by @ankona ]

---------

Co-authored-by: Christopher McBride <[email protected]>
  • Loading branch information
MattToast and ankona authored Feb 7, 2024
1 parent b84b49f commit 18fe50a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def has_ext_modules(_placeholder):
"tqdm>=4.50.2",
"filelock>=3.4.2",
"protobuf~=3.20",
"watchdog>=3.0.0",
"watchdog>=3.0.0,<4.0.0",
]

# Add SmartRedis at specific version
Expand Down
2 changes: 1 addition & 1 deletion smartsim/_core/config/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def telemetry_frequency(self) -> int:

@property
def telemetry_enabled(self) -> bool:
return int(os.environ.get("SMARTSIM_FLAG_TELEMETRY", "0")) > 0
return int(os.environ.get("SMARTSIM_FLAG_TELEMETRY", "1")) > 0

@property
def telemetry_cooldown(self) -> int:
Expand Down
2 changes: 1 addition & 1 deletion smartsim/_core/utils/serialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def save_launch_manifest(manifest: _Manifest[TStepLaunchMetaData]) -> None:
manifest_dict = {
"schema info": {
"schema_name": "entity manifest",
"version": "0.0.2",
"version": "0.0.3",
},
"experiment": {
"name": manifest.metadata.exp_name,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_redis_cli():
pytest.param("0", False, id="letter zero"),
pytest.param("1", True, id="letter one"),
pytest.param("-1", False, id="letter negative one"),
pytest.param(None, False, id="not in env"),
pytest.param(None, True, id="not in env"),
],
)
def test_telemetry_flag(
Expand Down

0 comments on commit 18fe50a

Please sign in to comment.