Skip to content

Commit

Permalink
remove smart build --keydb argument and test
Browse files Browse the repository at this point in the history
  • Loading branch information
ankona committed Oct 18, 2024
1 parent 01d2eea commit 59f908e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions smartsim/_core/_cli/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,3 @@ def configure_parser(parser: argparse.ArgumentParser) -> None:
type=str,
help="Path to directory with JSON files describing platform and packages",
)
parser.add_argument(
"--keydb",
action="store_true",
default=False,
help="Build KeyDB instead of Redis",
)
1 change: 0 additions & 1 deletion tests/_legacy/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ def mock_execute(ns: argparse.Namespace, _unparsed: t.Optional[t.List[str]] = No
pytest.param( "build", "build_execute", "onnx mocked-build", "--skip-onnx", True, "", "onnx", True, id="Skip Onnx"),
pytest.param( "build", "build_execute", "config-dir mocked-build", "--config-dir /foo/bar", True, "", "config-dir", "/foo/bar", id="set torch dir"),
pytest.param( "build", "build_execute", "bad-config-dir mocked-build", "--config-dir", False, "error: argument --config-dir", "", "", id="set config dir w/o path"),
pytest.param( "build", "build_execute", "keydb mocked-build", "--keydb", True, "", "keydb", True, id="keydb on"),
pytest.param( "clean", "clean_execute", "clobbering mocked-clean", "--clobber", True, "", "clobber", True, id="clean w/clobber"),
pytest.param("validate", "validate_execute", "port mocked-validate", "--port=12345", True, "", "port", 12345, id="validate w/ manual port"),
pytest.param("validate", "validate_execute", "abbrv port mocked-validate", "-p 12345", True, "", "port", 12345, id="validate w/ manual abbreviated port"),
Expand Down

0 comments on commit 59f908e

Please sign in to comment.