Skip to content

Commit

Permalink
Remove duplicate launched model names from full test suite (#520)
Browse files Browse the repository at this point in the history
Removes behavior deprecated in #480 from test suite.

[ committed by @MattToast ]
[ reviewed by @mellis13 ]
  • Loading branch information
MattToast authored Mar 18, 2024
1 parent e307b72 commit 6dea582
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 7 additions & 3 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Description
- Update the version of Redis from `7.0.4` to `7.2.4`
- Fix publishing of development docs
- Update Experiment API typing
- Minor enhancements to test suite

Detailed Notes

Expand All @@ -48,15 +49,18 @@ Detailed Notes
software and files that come from the default Github Ubuntu container.
(SmartSim-PR504_)
- Update the generic `t.Any` typehints in Experiment API. (SmartSim-PR501_)
- Remove previously deprecated behavior present in test suite on machines with
Slurm and Open MPI. (SmartSim-PR520_)

.. _SmartSim-PR517: https://github.com/CrayLabs/SmartSim/pull/517
.. _SmartSim-PR512: https://github.com/CrayLabs/SmartSim/pull/512
.. _SmartSim-PR520: https://github.com/CrayLabs/SmartSim/pull/520
.. _SmartSim-PR518: https://github.com/CrayLabs/SmartSim/pull/518
.. _SmartSim-PR517: https://github.com/CrayLabs/SmartSim/pull/517
.. _SmartSim-PR514: https://github.com/CrayLabs/SmartSim/pull/514
.. _SmartSim-PR463: https://github.com/CrayLabs/SmartSim/pull/463
.. _SmartSim-PR512: https://github.com/CrayLabs/SmartSim/pull/512
.. _SmartSim-PR507: https://github.com/CrayLabs/SmartSim/pull/507
.. _SmartSim-PR504: https://github.com/CrayLabs/SmartSim/pull/504
.. _SmartSim-PR501: https://github.com/CrayLabs/SmartSim/pull/501
.. _SmartSim-PR463: https://github.com/CrayLabs/SmartSim/pull/463


0.6.2
Expand Down
4 changes: 3 additions & 1 deletion tests/full_wlm/test_mpmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ def prune_commands(launcher):
settings.make_mpmd(deepcopy(settings))
settings.make_mpmd(deepcopy(settings))

mpmd_model = exp.create_model("mmpd", path=test_dir, run_settings=settings)
mpmd_model = exp.create_model(
f"mpmd-{run_command}", path=test_dir, run_settings=settings
)
exp.start(mpmd_model, block=True)
statuses = exp.get_status(mpmd_model)
assert all([stat == SmartSimStatus.STATUS_COMPLETED for stat in statuses])
Expand Down

0 comments on commit 6dea582

Please sign in to comment.