Skip to content

Commit

Permalink
fixed merge onflicts with smartsim-refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
juliaputko committed Aug 21, 2024
2 parents 333ff32 + 0569c05 commit 8a9cbe2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion smartsim/_core/shell/shellLauncher.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
from smartsim._core.utils.launcher import ExecutableProtocol, create_job_id
from smartsim.error import errors
from smartsim.log import get_logger
from smartsim.settings.arguments.launchArguments import LaunchArguments
from smartsim.status import JobStatus
from smartsim.types import LaunchedJobID

Expand Down Expand Up @@ -122,7 +123,7 @@ def make_shell_format_fn(
as_srun_command = make_shell_format_fn("srun")
fmt_cmd = as_srun_command(slurm_args, echo_hello_world, env)
print(list(fmt_cmd))
# prints: "['srun', --export ALL,foo=bar,baz=meep,spam=eggs '--nodes=3', '--', 'echo', 'Hello World!']"
# prints: "['srun', '--nodes=3', '--', 'echo', 'Hello World!']"
.. note::
This function was/is a kind of slap-dash implementation, and is likely
Expand Down

0 comments on commit 8a9cbe2

Please sign in to comment.