Skip to content

Commit

Permalink
Remove stale FIXME comment
Browse files Browse the repository at this point in the history
  • Loading branch information
MattToast authored Jul 16, 2024
1 parent 44ba1eb commit 9797442
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions smartsim/settings/launchSettings.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,6 @@ def launcher(self) -> str:
@property
def launch_args(self) -> LaunchArgBuilder[t.Any]:
"""Return the launch argument translator."""
# FIXME: We _REALLY_ need to make the `LaunchSettings` class generic at
# on `_arg_builder` if we are expecting users to call specific
# `set_*` methods defined specificially on each of the
# subclasses. Otherwise we have no way of showing what methods
# are available at intellisense/static analysis/compile time.
# This whole object basically resolves to being one step removed
# from `Any` typed (worse even, as type checkers will error)!!
return self._arg_builder

@launch_args.setter
Expand Down

0 comments on commit 9797442

Please sign in to comment.