Command Generation #615
Command Generation #615
Conversation
MattToast
force-pushed
the
smartsim-refactor
branch
2 times, most recently
from
d15e951 to
e9d8eca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #615 +/- ##
====================================================
Coverage ? 32.93%
====================================================
Files ? 107
Lines ? 6401
Branches ? 0
====================================================
Hits ? 2108
Misses ? 4293
Partials ? 0 |
| "5": 10, | ||
| "FIRST": "SECOND", | ||
| "17": 20, |
There was a problem hiding this comment.
Not strictly wrong, but thought I should call it out: in theory you should only need to handle a param mapping of type dict[str, str]. If you can handle more types that's great but don't feel the need to explicitly test for it!
There was a problem hiding this comment.
this is carry over from previous tests. I can remove it if you think its irrelevant
There was a problem hiding this comment.
I'd say either assume a dict[str, str] or introduce a type alias so that we know exactly what you are expecting before we serialize and send a command over the wire
| def test_configure_invalid_tags(fileutils): | ||
| """Test configure operation with an invalid tag""" | ||
| tagged_file = fileutils.get_test_conf_path( | ||
| osp.join("generator_files", "easy", "marked", "invalidtag.txt") |
There was a problem hiding this comment.
I'm slightly hurt that you thought my test was easy, hahahaha
Co-authored-by: Matt Drozt <[email protected]>
juliaputko
merged commit 9b511f1
into
CrayLabs:smartsim-refactor
No description provided.