Generator class refactor and inject path into Dragon & Shell Launcher #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REBASEME: moar mpi REBASEME: fmt mpi
amandarichardsonn
added
area: job
juliaputko
reviewed
Jul 17, 2024
| msg=f"Configured application {entity.name} with no parameters", | ||
| ) | ||
|
|
||
| # if entity.files: |
| @@ -71,7 +74,7 @@ def unpack_colo_fs_identifier(fs_id: str) -> str: | |||
| return "_" + fs_id if fs_id else "" | |||
|
|
|||
|
|
|||
| def create_short_id_str() -> str: | |||
| def create_short_id_str() -> str: # here | |||
| exe, *rest = launchable | ||
| self._launched[id_] = sp.Popen( | ||
| (helpers.expand_exe_path(exe), *rest), cwd=job_execution_path | ||
| ) # can specify a different dir for Popen |
There was a problem hiding this comment.
change to a todo or remove comment?
| """Test if the log level is DEBUG when environment variable is set to "debug".""" | ||
| environ["SMARTSIM_LOG_LEVEL"] = "debug" | ||
| assert gen_instance_for_job.log_level == DEBUG | ||
| # Clean up: unset the environment variable |
amandarichardsonn
force-pushed
the
path-injection
branch
from
f83cddf to
2a667f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR located at:
https://github.com/MattToast/SmartSim/pull/3#issue-2414877973