Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link up SmartSim Refactor CI #646

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

MattToast
Copy link
Member

Add headers/marks/boilerplate to test files for smartsim-refactor

@MattToast MattToast added area: CI/CD Issues related to continuous integration and deployment ignore-for-release labels Jul 23, 2024
@MattToast MattToast self-assigned this Jul 23, 2024
Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Really support your idea of a check, mayhaps could add it in this PR

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (smartsim-refactor@c2164ca). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             smartsim-refactor     #646   +/-   ##
====================================================
  Coverage                     ?   33.26%           
====================================================
  Files                        ?      107           
  Lines                        ?     6401           
  Branches                     ?        0           
====================================================
  Hits                         ?     2129           
  Misses                       ?     4272           
  Partials                     ?        0           

@MattToast MattToast merged commit b965c3d into CrayLabs:smartsim-refactor Jul 24, 2024
32 of 33 checks passed
@MattToast MattToast deleted the link-up-ci branch July 25, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment ignore-for-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants